bpo-45678: Add functools.singledispatchmethod tests #29328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ambv added needs backport to 3.9 
bedevere-bot removed the 🔨 test-with-buildbots 
| All buildbot failures but one are on The only buildbot that failed on a non-sqlite test was "AMD64 FreeBSD Shared PR", where |
| Thanks @AlexWaygood for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 3, 2021
(cherry picked from commit 5a14929) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
| GH-29390 is a backport of this pull request to the 3.10 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 3, 2021
(cherry picked from commit 5a14929) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
| GH-29391 is a backport of this pull request to the 3.9 branch. |
AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Nov 3, 2021
…od` bug This PR fixes a bug in the 3.9 branch where ``functools.singledispatchmethod`` did not properly wrap attributes such as ``__name__``, ``__doc__`` and ``__module__`` of the target method. It also backports tests already merged into the 3.11 and 3.10 branches in #python#29328 and python#29390.
| As discussed in #29391, the attempted backport of this PR by @miss-islington to Python 3.9 exposed a bug in that branch. A new bugfix/backport PR is here: #29394 |
ambv added a commit that referenced this pull request Nov 4, 2021
…od` bug (GH-29394) This PR fixes a bug in the 3.9 branch where ``functools.singledispatchmethod`` did not properly wrap attributes such as ``__name__``, ``__doc__`` and ``__module__`` of the target method. It also backports tests already merged into the 3.11 and 3.10 branches in #29328 and #29390. Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue45678