Skip to content

bpo-45557: Fix underscore_numbers in pprint.pprint(). #29129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2021
Merged

bpo-45557: Fix underscore_numbers in pprint.pprint(). #29129

merged 2 commits into from
Oct 21, 2021
+4 −1

Conversation

@ericvsmith
Copy link
Member

@ericvsmith ericvsmith commented Oct 21, 2021 •
edited by bedevere-bot
Loading

pprint.pprint() always passes underscore_numbers=False to pformat(), it should use underscore_numbers=underscore_numbers.

https://bugs.python.org/issue45557
@ericvsmith ericvsmith self-assigned this Oct 21, 2021
@ericvsmith ericvsmith added the needs backport to 3.10 only security fixes label Oct 21, 2021
@ericvsmith
Copy link
Member Author

There's no test for this, because in general the pprint module doesn't test pprint.pprint(). I'll open an issue for that.
@ericvsmith
Copy link
Member Author

I created https://bugs.python.org/issue45559 for testing pprint.pprint().
@ericvsmith ericvsmith merged commit 087f089 into python:main Oct 21, 2021
@miss-islington
Copy link
Contributor

Thanks @ericvsmith for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 21, 2021
@ericvsmith @miss-islington
bpo-45557: Fix underscore_numbers in pprint.pprint(). (pythonGH-29129)
82cf867 
(cherry picked from commit 087f089) Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
@bedevere-bot
Copy link

GH-29133 is a backport of this pull request to the 3.10 branch.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 21, 2021
@ericvsmith ericvsmith deleted the issue45557 branch October 21, 2021 20:43
miss-islington added a commit that referenced this pull request Oct 21, 2021
@miss-islington @ericvsmith
bpo-45557: Fix underscore_numbers in pprint.pprint(). (GH-29129)
6b75ad5 
(cherry picked from commit 087f089) Co-authored-by: Eric V. Smith <ericvsmith@users.noreply.github.com>
@erlend-aasland erlend-aasland mentioned this pull request Oct 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants

@ericvsmith @miss-islington @bedevere-bot @zware @jpvincent1980 @the-knights-who-say-ni