Skip to content

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Jul 27, 2021

@pablogsal
Copy link
Member Author

One possibility we can do is eliminate the custom code and just go with this error always (no "did you mean 'print(...)'").

Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice improvement.

Copy link
Member

@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal pablogsal merged commit 6948964 into python:main Jul 27, 2021
@pablogsal pablogsal deleted the bpo-34013 branch July 27, 2021 16:19
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6948964ecf94e858448dd28eea634317226d2913 3.10

@bedevere-bot
Copy link

GH-27391 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 27, 2021
pablogsal added a commit to pablogsal/cpython that referenced this pull request Jul 27, 2021
…ge (pythonGH-27389). (cherry picked from commit 6948964) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Jul 27, 2021
…ge (GH-27389). (GH-27391) (cherry picked from commit 6948964) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants