bpo-30917: IDLE: Add config.IdleConf unittest

Lib/idlelib/config.py

@@ -30,6 +30,7 @@
 import sys
 
 from tkinter.font import Font
+import idlelib
 
 class InvalidConfigType(Exception): pass
 class InvalidConfigSet(Exception): pass
@@ -216,7 +217,8 @@ def GetUserCfgDir(self):
  except OSError:
  warn = ('\n Warning: unable to create user config directory\n' +
  userDir + '\n Check path and permissions.\n Exiting!\n')
- print(warn, file=sys.stderr)
+ if not idlelib.testing:
+ print(warn, file=sys.stderr)
  raise SystemExit
  # TODO continue without userDIr instead of exit
  return userDir

Lib/idlelib/idle_test/test_config.py

@@ -1,9 +1,8 @@
 '''Test idlelib.config.
 
-Coverage: 46% (100% for IdleConfParser, IdleUserConfParser*, ConfigChanges).
-* Except is OSError clause in Save method.
-Much of IdleConf is exercised by ConfigDialog and test_configdialog,
-but it should be tested here.
+Coverage: 96% (100% for IdleConfParser, IdleUserConfParser*, ConfigChanges).
+* Exception is OSError clause in Save method.
+Much of IdleConf is also exercised by ConfigDialog and test_configdialog.
 '''
 import copy
 import sys
@@ -12,7 +11,9 @@
 from test.support import captured_stderr, findfile
 import unittest
 from unittest import mock
+import idlelib
 from idlelib import config
+from idlelib.idle_test.mock_idle import Func
 
 # Tests should not depend on fortuitous user configurations.
 # They must not affect actual user .cfg files.
@@ -28,9 +29,11 @@
 
 def setUpModule():
  idleConf.userCfg = testcfg
+ idlelib.testing = True
 
 def tearDownModule():
  idleConf.userCfg = usercfg
+ idlelib.testing = False
 
 
 class IdleConfParserTest(unittest.TestCase):
@@ -204,6 +207,12 @@ def setUpClass(cls):
  conf.userCfg[ctype] = config.IdleUserConfParser(config_path)
  conf.LoadCfgFiles()
  cls.conf = conf
+ cls.orig_warn = config._warn
+ config._warn = Func()
+
+ @classmethod
+ def tearDownClass(cls):
+ config._warn = cls.orig_warn
 
  def new_config(self, _utest=False):
  return config.IdleConf(_utest=_utest)

Misc/NEWS.d/next/IDLE/2017-07-17-23-35-57.bpo-30917.hSiuuO.rst

@@ -0,0 +1,3 @@
+Add tests for idlelib.config.IdleConf.
+Increase coverage from 46% to 96%.
+Patch by Louie Lu.