Skip to content

[3.10] bpo-42972: Fully implement GC protocol for functools LRU cache (GH-26423) #26425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2021
Merged

[3.10] bpo-42972: Fully implement GC protocol for functools LRU cache (GH-26423) #26425

merged 1 commit into from
May 28, 2021

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 28, 2021 •
edited by bedevere-bot
Loading

(cherry picked from commit 3f8d332)

Co-authored-by: Erlend Egeberg Aasland erlend.aasland@innova.no

https://bugs.python.org/issue42972
@miss-islington
bpo-42972: Fully implement GC protocol for functools LRU cache (pytho…
2e1b3b7 
…nGH-26423) (cherry picked from commit 3f8d332) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@miss-islington
Copy link
Contributor Author

@erlend-aasland and @vstinner: Status check is done, and it's a success ✅ .
@bedevere-bot bedevere-bot mentioned this pull request May 28, 2021
Merged
vstinner
vstinner approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.
@miss-islington
Copy link
Contributor Author

@erlend-aasland and @vstinner: Status check is done, and it's a success ❌ .
@miss-islington
Copy link
Contributor Author

@erlend-aasland and @vstinner: Status check is done, and it's a success ✅ .
@miss-islington
Copy link
Contributor Author

Sorry, I can't merge this PR. Reason: 2 of 5 required status checks are expected..
@vstinner
Copy link
Member

Windows (x64) failed with: https://bugs.python.org/issue44252

test_host_port (test.test_httplib.HTTPSTest) ... ok Windows fatal exception: access violation ...

I re-run the CI jobs.
@miss-islington
Copy link
Contributor Author

@erlend-aasland and @vstinner: Status check is done, and it's a success ✅ .
@miss-islington miss-islington merged commit 1c0106c into python:3.10 May 28, 2021
@miss-islington miss-islington deleted the backport-3f8d332-3.10 branch May 28, 2021 14:26
@vstinner vstinner mentioned this pull request Jun 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news

4 participants

@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot