bpo-44125: Fix "make patchcheck" on non-English locale #26102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pitrou added needs backport to 3.9 needs backport to 3.10 
pitrou added 🤖 automerge awaiting core review awaiting merge and removed awaiting merge awaiting core review labels 
| @pitrou: Status check is done, and it's a success ✅ . |
| Thanks @pitrou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 13, 2021
The patch from [bpo-44074]() does not account for a possibly non-English locale and blindly greps for "HEAD branch" in a possibly localized text. Automerge-Triggered-By: GH:pitrou (cherry picked from commit 1aa3530) Co-authored-by: Antoine Pitrou <antoine@python.org>
| GH-26105 is a backport of this pull request to the 3.10 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 13, 2021
The patch from [bpo-44074]() does not account for a possibly non-English locale and blindly greps for "HEAD branch" in a possibly localized text. Automerge-Triggered-By: GH:pitrou (cherry picked from commit 1aa3530) Co-authored-by: Antoine Pitrou <antoine@python.org>
| GH-26106 is a backport of this pull request to the 3.9 branch. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The patch from bpo-44074 does not account for a possibly non-English locale and blindly greps for "HEAD branch" in a possibly localized text.
https://bugs.python.org/issue44125
Automerge-Triggered-By: GH:pitrou