Skip to content

Conversation

@Llandy3d
Copy link
Contributor

@Llandy3d Llandy3d commented Apr 25, 2021

Update documentation to reflect that dataclasses.FrozenInstanceError is derived by AttributeError.

https://bugs.python.org/issue43938

https://bugs.python.org/issue43938

@Llandy3d Llandy3d requested a review from ericvsmith as a code owner April 25, 2021 20:51
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Llandy3d

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks. After you sign the CLA I'll merge it.

@miss-islington
Copy link
Contributor

Thanks @Llandy3d for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 26, 2021
…honGH-25603) (cherry picked from commit 8a307e4) Co-authored-by: Llandy Riveron Del Risco <llandy3d@gmail.com>
@bedevere-bot
Copy link

GH-25635 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link

GH-25636 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 26, 2021
…honGH-25603) (cherry picked from commit 8a307e4) Co-authored-by: Llandy Riveron Del Risco <llandy3d@gmail.com>
@Llandy3d Llandy3d deleted the bpo-43938-improve-doc branch April 26, 2021 18:57
ericvsmith pushed a commit that referenced this pull request Apr 26, 2021
…25603) (GH-25636) (cherry picked from commit 8a307e4) Co-authored-by: Llandy Riveron Del Risco <llandy3d@gmail.com> Co-authored-by: Llandy Riveron Del Risco <llandy3d@gmail.com>
ericvsmith pushed a commit that referenced this pull request Apr 26, 2021
…25603) (GH-25635) (cherry picked from commit 8a307e4) Co-authored-by: Llandy Riveron Del Risco <llandy3d@gmail.com> Co-authored-by: Llandy Riveron Del Risco <llandy3d@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants