Skip to content

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Apr 14, 2021

Copy link
Member

@isidentical isidentical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Batuhan Taskaya <isidentical@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pablogsal pablogsal merged commit 5bf8bf2 into python:master Apr 14, 2021
@pablogsal pablogsal deleted the nameerrors branch April 14, 2021 14:11
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 10, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 11, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 11, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 11, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 11, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 13, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 13, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 13, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 13, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 14, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 14, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 14, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 15, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 16, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 18, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 18, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 20, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 20, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants