-
- Notifications
You must be signed in to change notification settings - Fork 33.2k
bpo-38530: Offer suggestions on NameError #25397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
5b98377
to 6e4fe45
Compare isidentical approved these changes Apr 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Misc/NEWS.d/next/Core and Builtins/2021-04-14-03-53-06.bpo-38530.rNI_G1.rst Outdated Show resolved Hide resolved
vstinner reviewed Apr 14, 2021
Co-authored-by: Batuhan Taskaya <isidentical@gmail.com> Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner approved these changes Apr 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 10, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 11, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 11, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 11, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 11, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 13, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 13, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 13, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 13, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 14, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 14, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 14, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 15, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 16, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 18, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 18, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 20, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Snowapril added a commit to Snowapril/RustPython that referenced this pull request Oct 20, 2021
`suggestions.rs` is almost porting of implementation of [this](python/cpython#16856) and [this](python/cpython#25397). Signed-off-by: snowapril <sinjihng@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue38530