Skip to content

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Dec 13, 2020

@pablogsal
Copy link
Member Author

@lysnikolaou I was in automatic mode and I realized that I opened the PR without considering if you would have preferred to open it yourself. Please, feel free to close this and open one yourself if you prefer so :)

Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No wories at all @pablogsal!

@lysnikolaou
Copy link
Member

I think there's also a test that needs changing in test_exceptions, testSyntaxErrorOffset.

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup!

@pablogsal pablogsal merged commit 43c4fb6 into python:master Dec 13, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
…ythonGH-23753) Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@pablogsal pablogsal deleted the bpo-30858 branch May 19, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants