bpo-29176 Use tmpfile() in curses module #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tiran changed the title 
vstinner reviewed Feb 22, 2017
Modules/_cursesmodule.c Outdated
Modules/_cursesmodule.c Outdated
There was a problem hiding this comment.
= NULL can be removed
Same remarks for the other function.
tiran force-pushed the bpo29176_curses_tmpfile branch 2 times, most recently from 7b11476 to a16b7b5 Compare vstinner approved these changes Feb 22, 2017
tiran force-pushed the bpo29176_curses_tmpfile branch from a16b7b5 to 22fdd41 Compare 
Modules/_cursesmodule.c Outdated
| I think an entry in Misc/NEWS is required. |
From an user point of view, there is no change, except of Android support. Last days, I'm trying to avoid touching Misc/NEWS, because it's even more a mess because of how pull requests work :-( |
tiran force-pushed the bpo29176_curses_tmpfile branch from 22fdd41 to 0e00de8 Compare The curses module used mkstemp() + fopen() to create a temporary file in /tmp. The /tmp directory does not exist on Android. The tmpfile() function simplifies the task a lot. It creates a temporary file in a correct directory, takes care of cleanup and returns FILE*. tmpfile is supported on all platforms (C89, POSIX 2001, Android, Windows). Signed-off-by: Christian Heimes <christian@python.org>
tiran force-pushed the bpo29176_curses_tmpfile branch from 0e00de8 to 8353365 Compare 
vstinner approved these changes Mar 2, 2017
yan12125 added a commit to yan12125/python3-android that referenced this pull request Mar 2, 2017
akruis pushed a commit to akruis/cpython that referenced this pull request Apr 20, 2021
…#188 This commit fixes an assert statement, that could fail since python#188. No functional change. (cherry picked from commit 5595eec)
akruis pushed a commit to akruis/cpython that referenced this pull request May 27, 2021
…#188 This commit fixes an assert statement, that could fail since python#188. No functional change.
jaraco pushed a commit that referenced this pull request Dec 2, 2022
Bumps [cherry-picker](https://github.com/python/core-workflow) from 1.2.2 to 1.3.2. - [Release notes](https://github.com/python/core-workflow/releases) - [Commits](python/core-workflow@cherry-picker-v1.2.2...cherry-picker-v1.3.2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The curses module used mkstemp() + fopen() to create a temporary file in
/tmp. The /tmp directory does not exist on Android. The tmpfile()
function simplifies the task a lot. It creates a temporary file in a
correct directory, takes care of cleanup and returns FILE*.
tmpfile is supported on all platforms (C89, POSIX 2001, Android,
Windows).
https://bugs.python.org/issue29176
Signed-off-by: Christian Heimes christian@python.org