mark various test data binary #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
methane approved these changes Feb 22, 2017
Member
| What about other binary data? and others. |
Contributor Author
| We can add those, too, but git seems to at least automatically recognize them as binary. |
benjaminp added a commit that referenced this pull request Feb 26, 2017
benjaminp added a commit that referenced this pull request Feb 26, 2017
benjaminp added a commit that referenced this pull request Feb 26, 2017
benjaminp added a commit that referenced this pull request Feb 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
It seems git's automatic LF -> CRLF translation for some binary data files is breaking the Windows buildbots. (My favorite is
ModuleNotFoundError: No module named 'random\r'.) Turn that off .