Skip to content

bpo-40890: Add mapping attribute to dict views #20691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

bpo-40890: Add mapping attribute to dict views #20691

wants to merge 4 commits into from

Conversation

@sweeneyde
Copy link
Member

@sweeneyde sweeneyde commented Jun 7, 2020 •
edited by bedevere-bot
Loading

@sweeneyde sweeneyde requested a review from methane as a code owner June 7, 2020 08:56
remilapeyre
remilapeyre suggested changes Jun 7, 2020
View reviewed changes
Copy link

@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think MappingView in collections.abc will also need to be updated.
remilapeyre
remilapeyre reviewed Jun 7, 2020
View reviewed changes
@sweeneyde
Simplify wording of documentation
cec69cc 
Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
@sweeneyde
Copy link
Member Author

I think MappingView in collections.abc will also need to be updated.

I'm not convinced the spec should change. I wouldn't want to make it so that some user class is no longer implementing the MappingView interface if it had already registered as a MappingView but doesn't (or maybe even can't?) have a mapping property. For precedent, the dict views have __reversed__ methods, while MappingView has remained without. It seems that most of the ABC interfaces that have existed since the creation of the ABC module have remained stable ever since.
@sweeneyde sweeneyde closed this Jun 9, 2020
@sweeneyde sweeneyde deleted the dictview_mapping branch April 5, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review

4 participants

@sweeneyde @remilapeyre @the-knights-who-say-ni @bedevere-bot