Skip to content

bpo-40884: Added defaults parameter for logging.Formatter #20668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jun 18, 2020
Merged

bpo-40884: Added defaults parameter for logging.Formatter #20668

merged 20 commits into from
Jun 18, 2020

Conversation

bharel
Copy link
Contributor

@bharel bharel commented Jun 5, 2020 •
edited by miss-islington
Loading

Docs and tests are underway.

https://bugs.python.org/issue40884

Automerge-Triggered-By: @vsajip
@bharel bharel requested a review from vsajip as a code owner June 5, 2020 23:38
@bharel
Copy link
Contributor Author

bharel commented Jun 6, 2020

Added docs and tests, all should pass now.
ATM the feature is not implemented for ConfigFile or basicConfig.
Would you wish for me to implement it on both cases?
If so, how shall I name the parameter on basicConfig? (defaults will be a little weird in there)
@vsajip vsajip added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 17, 2020
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @vsajip for commit 4ba90e4 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 17, 2020
@miss-islington miss-islington merged commit 8f192d1 into python:master Jun 18, 2020
@vsajip
Copy link
Member

vsajip commented Jun 18, 2020

Would you wish for me to implement it on both cases?

No need.
@csabella
Copy link
Contributor

Nice!
@bharel bharel deleted the default-formatter-values branch June 18, 2020 21:37
@bharel bharel mentioned this pull request Jun 18, 2020
Closed
@bharel bharel mannequin mentioned this pull request Feb 4, 2023
Closed
@bharel bharel mentioned this pull request Apr 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

7 participants

@bharel @bedevere-bot @vsajip @csabella @PointDreck @the-knights-who-say-ni @miss-islington