bpo-40876: Clarify error message in the csv module #20653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cool-RR force-pushed the 2020-06-05-csv-text-mode branch from 2e07f8c to bb4cfc6 Compare cool-RR changed the title 
nanjekyejoannah approved these changes Jun 5, 2020
There was a problem hiding this comment.
Thanks for your contribution @cool-RR. There is no need for a news entry for small doc fixes.
| Yay :) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I was working with the csv module, and I vaguely remembered that you should open files in binary mode. So I did.
Then I saw this error message:
I read the end and thought "I didn't open it in text mode, what does it want from me?!" It took a careful reading to figure out that I was supposed to open it in text mode.
This PR slightly changes the text to:
https://bugs.python.org/issue40876