Skip to content

Conversation

@TIGirardi
Copy link
Contributor

@TIGirardi TIGirardi commented May 30, 2020

Use wide-char _W_* fields of lconv structure on Windows
Remove "ps_AF" from test__locale.known_numerics on Windows

https://bugs.python.org/issue38324

Use wide-char _W_* fields of lconv structure on Windows Remove "ps_AF" from test__locale.known_numerics on Windows
terryjreedy and others added 2 commits October 19, 2020 19:24
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
Co-authored-by: Steve Dower <steve.dower@microsoft.com>
@zooba zooba merged commit f231203 into python:master Oct 20, 2020
@miss-islington
Copy link
Contributor

Thanks @TIGirardi for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 20, 2020
Use wide-char _W_* fields of lconv structure on Windows Remove "ps_AF" from test__locale.known_numerics on Windows (cherry picked from commit f231203) Co-authored-by: TIGirardi <tiagoigirardi@gmail.com>
@bedevere-bot
Copy link

GH-22812 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 20, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 20, 2020
Use wide-char _W_* fields of lconv structure on Windows Remove "ps_AF" from test__locale.known_numerics on Windows (cherry picked from commit f231203) Co-authored-by: TIGirardi <tiagoigirardi@gmail.com>
@bedevere-bot
Copy link

GH-22813 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 20, 2020
Use wide-char _W_* fields of lconv structure on Windows Remove "ps_AF" from test__locale.known_numerics on Windows (cherry picked from commit f231203) Co-authored-by: TIGirardi <tiagoigirardi@gmail.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Clang Installed 3.x has failed when building commit f231203.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/531/builds/194) and take a look at the build logs.
  4. Check if the failure is related to this commit (f231203) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/531/builds/194

Failed tests:

  • test_lib2to3
  • test_os

Failed subtests:

  • test_utime_current - test.test_os.UtimeTests
  • test_utime_current_old - test.test_os.UtimeTests

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/test_os.py", line 756, in test_utime_current self._test_utime_current(set_time) File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/test_os.py", line 749, in _test_utime_current self.assertAlmostEqual(st.st_mtime, current, AssertionError: 1603195337.2286437 != 1603195337.3009357 within 0.05 delta (0.07229208946228027 difference) : st_time=1603195337.2286437, current=1603195337.3009357, dt=-0.07229208946228027 Traceback (most recent call last): File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/test_os.py", line 762, in test_utime_current_old self._test_utime_current(set_time) File "/home/dje/cpython-buildarea/3.x.edelsohn-fedora-z.clang-installed/build/target/lib/python3.10/test/test_os.py", line 749, in _test_utime_current self.assertAlmostEqual(st.st_mtime, current, AssertionError: 1603195337.2286437 != 1603195337.302309 within 0.05 delta (0.07366538047790527 difference) : st_time=1603195337.2286437, current=1603195337.302309, dt=-0.07366538047790527 
miss-islington added a commit that referenced this pull request Oct 20, 2020
Use wide-char _W_* fields of lconv structure on Windows Remove "ps_AF" from test__locale.known_numerics on Windows (cherry picked from commit f231203) Co-authored-by: TIGirardi <tiagoigirardi@gmail.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Use wide-char _W_* fields of lconv structure on Windows Remove "ps_AF" from test__locale.known_numerics on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants