Skip to content

Conversation

DahlitzFlorian
Copy link
Contributor

@DahlitzFlorian DahlitzFlorian commented May 28, 2020

@remilapeyre I did not include a news entry as it only affects the documentation.

https://bugs.python.org/issue40798

Copy link
Contributor

@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DahlitzFlorian !

Copy link
Contributor

@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DahlitzFlorian, this looks great!

@DahlitzFlorian
Copy link
Contributor Author

Thanks for the guidance @remilapeyre!

@JulienPalard
Copy link
Member

Thanks @DahlitzFlorian I like it a lot!

Could you just add the new string to Doc/tools/templates/dummy.html so it get picked up by gettext and get translated?

@DahlitzFlorian
Copy link
Contributor Author

Thanks for the feedback and pointing me at the translation part, @JulienPalard!

@JulienPalard
Copy link
Member

JulienPalard commented May 30, 2020

Thanks @DahlitzFlorian! I'll be happy to see it in prod (and translated!)!

@JulienPalard JulienPalard merged commit 735d902 into python:master May 30, 2020
@miss-islington
Copy link
Contributor

Thanks @DahlitzFlorian for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-20531 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link

GH-20532 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2020
…ythonGH-20483) (cherry picked from commit 735d902) Co-authored-by: Florian Dahlitz <f2dahlitz@freenet.de>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 30, 2020
…ythonGH-20483) (cherry picked from commit 735d902) Co-authored-by: Florian Dahlitz <f2dahlitz@freenet.de>
@bedevere-bot
Copy link

GH-20533 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request May 30, 2020
…H-20483) (cherry picked from commit 735d902) Co-authored-by: Florian Dahlitz <f2dahlitz@freenet.de>
miss-islington added a commit that referenced this pull request May 30, 2020
…H-20483) (cherry picked from commit 735d902) Co-authored-by: Florian Dahlitz <f2dahlitz@freenet.de>
miss-islington added a commit that referenced this pull request May 30, 2020
…H-20483) (cherry picked from commit 735d902) Co-authored-by: Florian Dahlitz <f2dahlitz@freenet.de>
@DahlitzFlorian DahlitzFlorian deleted the fix-issue-40798 branch May 30, 2020 08:01
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request May 30, 2020
* 'master' of github.com:python/cpython: (497 commits) bpo-40061: Fix a possible refleak in _asynciomodule.c (pythonGH-19748) bpo-40798: Generate a different message for already removed elements (pythonGH-20483) closes bpo-29017: Update the bindings for Qt information with PySide2 (pythonGH-20149) bpo-39885: Make IDLE context menu cut and copy work again (pythonGH-18951) bpo-29882: Add an efficient popcount method for integers (python#771) Further de-linting of zoneinfo module (python#20499) bpo-40780: Fix failure of _Py_dg_dtoa to remove trailing zeros (pythonGH-20435) Indicate that abs() method accept argument that implement __abs__(), just like call() method in the docs (pythonGH-20509) bpo-39040: Fix parsing of email mime headers with whitespace between encoded-words. (pythongh-17620) bpo-40784: Fix sqlite3 deterministic test (pythonGH-20448) bpo-30064: Properly skip unstable loop.sock_connect() racing test (pythonGH-20494) Note the output ordering of combinatoric functions (pythonGH-19732) bpo-40474: Updated coverage.yml to better report coverage stats (python#19851) bpo-40806: Clarify that itertools.product immediately consumes its inpt (pythonGH-20492) bpo-1294959: Try to clarify the meaning of platlibdir (pythonGH-20332) bpo-37878: PyThreadState_DeleteCurrent() was not removed (pythonGH-20489) bpo-40777: Initialize PyDateTime_IsoCalendarDateType.tp_base at run-time (pythonGH-20493) bpo-40755: Add missing multiset operations to Counter() (pythonGH-20339) bpo-25920: Remove socket.getaddrinfo() lock on macOS (pythonGH-20177) bpo-40275: Fix test.support.threading_helper (pythonGH-20488) ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

6 participants