Skip to content

bpo-40067 : Improve error messages for multiple star expressions in assignment #19168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 26, 2020
Merged

bpo-40067 : Improve error messages for multiple star expressions in assignment #19168

merged 11 commits into from
Mar 26, 2020

Conversation

@furkanonder
Copy link
Contributor

@furkanonder furkanonder commented Mar 25, 2020 •
edited by bedevere-bot
Loading

@furkanonder furkanonder changed the title Improve error messages for multiple star expressions in assignment bpo-40067 : Improve error messages for multiple star expressions in assignment Mar 25, 2020
isidentical
isidentical reviewed Mar 25, 2020
View reviewed changes
@furkanonder @isidentical
Update Misc/NEWS.d/next/Core and Builtins/2020-03-25-20-34-01.bpo-40067…
dfbca29 
….0bFda2.rst Co-Authored-By: Batuhan Taşkaya <isidentical@gmail.com>
isidentical
isidentical reviewed Mar 25, 2020
View reviewed changes
@isidentical isidentical requested a review from pablogsal March 25, 2020 21:34
@pablogsal
Copy link
Member

Thanks for your first contribution @furkanonder ! If you wish, you can also add yourself to the https://github.com/python/cpython/blob/master/Misc/ACKS file.
@pablogsal
Copy link
Member

Many thanks also @isidentical for the review :) 🎉
@furkanonder
Copy link
Contributor Author

Thanks for your first contribution @furkanonder ! If you wish, you can also add yourself to the https://github.com/python/cpython/blob/master/Misc/ACKS file.

Thank you very much for your review :) I added myself to ASK file.
Can you review again the PR?
@furkanonder furkanonder requested a review from pablogsal March 25, 2020 22:12
pablogsal
pablogsal approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@pablogsal pablogsal merged commit cb6534e into python:master Mar 26, 2020
isidentical added a commit to isidentical/parso that referenced this pull request May 21, 2020
@isidentical
Adapt Python3.9 errors on multiple star target
e18383e 
In Python3.9, the message "two starred expression in ..." changed to "multiple starred expression in ...", with python/cpython#19168
@isidentical isidentical mentioned this pull request May 21, 2020
Merged
davidhalter pushed a commit to davidhalter/parso that referenced this pull request May 21, 2020
@isidentical @davidhalter
Adapt Python3.9 errors on multiple star target
f870985 
In Python3.9, the message "two starred expression in ..." changed to "multiple starred expression in ...", with python/cpython#19168
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants

@furkanonder @pablogsal @isidentical @the-knights-who-say-ni @bedevere-bot