Doc nits for bpo-16500 #1841
Merged
Doc nits for bpo-16500 #1841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @pitrou, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rhettinger, @benjaminp and @serhiy-storchaka to be potential reviewers. |
Member
serhiy-storchaka left a comment
serhiy-storchaka left a comment There was a problem hiding this comment.
PyOS_AfterFork() also is mentioned in Doc/c-api/init.rst.
Member Author
| Thanks @serhiy-storchaka, for some reason I had overlooked it. |
serhiy-storchaka approved these changes May 28, 2017
Member
serhiy-storchaka left a comment
serhiy-storchaka left a comment There was a problem hiding this comment.
LGTM.
But maybe Doc/c-api/init.rst needs more updates.
| into Python) may result in a deadlock by one of Python's internal locks | ||
| being held by a thread that is defunct after the fork. | ||
| :c:func:`PyOS_AfterFork` tries to reset the necessary locks, but is not | ||
| :c:func:`PyOS_AfterFork_Child` tries to reset the necessary locks, but is not |
Member
There was a problem hiding this comment.
Is it worth to update the first part of this paragraph according to new API?
Member
There was a problem hiding this comment.
"there is no way to inform Python of additional (non-Python) locks that need to be acquired before or reset after a fork" and mentioning pthread_atfork.
ma8ma added a commit to ma8ma/cpython that referenced this pull request Jun 13, 2017
Resolve conflicts: f7ecfac Doc nits for bpo-16500 (python#1841)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.