bpo-29941: Add --with-assertions configure flag to enable C assertions. #1731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
'no', but as before assertions are implied by --with-pydebug.
| @Yhg1s, thanks for your PR! By analyzing the history of the files in this pull request, we identified @loewis, @doko42 and @jackjansen to be potential reviewers. |
gpshead approved these changes May 22, 2017
| Redo of #980 to fix merge glitches. As discussed there, this is technically a build enhancement but we should backport it to 3.6 anyway. |
| should also be fine in 2.7 as well. it isn't something that would ship in an interpreter, it's a developer code health sanity check flag. |
Yhg1s added a commit to Yhg1s/cpython that referenced this pull request May 22, 2017
…honGH-1731) Defaults to 'no', but as before assertions are implied by --with-pydebug.. (cherry picked from commit ddbfa2c)
ambv pushed a commit that referenced this pull request May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add --with-assertions configure flag to enable C assertions. Defaults to 'no', but as before assertions are implied by --with-pydebug.