Skip to content

bpo-38249: Expand Py_UNREACHABLE() to __builtin_unreachable() in the release mode. #16329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 9, 2020
Merged

bpo-38249: Expand Py_UNREACHABLE() to __builtin_unreachable() in the release mode. #16329

merged 10 commits into from
Mar 9, 2020

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Sep 22, 2019 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added the performance Performance or resource usage label Sep 22, 2019
ammaraskar
ammaraskar reviewed Sep 22, 2019
View reviewed changes
vstinner
vstinner reviewed Mar 9, 2020
View reviewed changes
@serhiy-storchaka
Copy link
Member Author

Thank you for your suggestions Victor and Ammar!
vstinner
vstinner approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

With the updated doc, it is easier for me to tell that the PR is consistent :-)
@serhiy-storchaka serhiy-storchaka merged commit eebaa9b into python:master Mar 9, 2020
@serhiy-storchaka serhiy-storchaka deleted the Py_UNREACHABLE-builtin_unreachable branch March 9, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Performance or resource usage

5 participants

@serhiy-storchaka @vstinner @ammaraskar @the-knights-who-say-ni @bedevere-bot