bpo-34706: Preserve subclassing in inspect.Signature.from_callable #16108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Specifically in the case of a class that does not override its constructor signature inherited from object. These are Buck Evan @bukzor's changes cherrypicked from PR 9344.
Addresses PR 9344 feedback.
Contributor
| Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
| GH-16113 is a backport of this pull request to the 3.8 branch. |
| GH-16114 is a backport of this pull request to the 3.7 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 13, 2019
…ythonGH-16108) https://bugs.python.org/issue34706 Specifically in the case of a class that does not override its constructor signature inherited from object. These are Buck Evan @bukzor's changes cherrypicked from pythonGH-9344. (cherry picked from commit 5b9ff7a) Co-authored-by: Gregory P. Smith <greg@krypto.org>
matrixise pushed a commit that referenced this pull request Sep 13, 2019
…H-16108) (GH-16113) https://bugs.python.org/issue34706 Specifically in the case of a class that does not override its constructor signature inherited from object. These are Buck Evan @bukzor's changes cherrypicked from GH-9344. (cherry picked from commit 5b9ff7a) Co-authored-by: Gregory P. Smith <greg@krypto.org>
matrixise pushed a commit that referenced this pull request Sep 13, 2019
…H-16108) (GH-16114) https://bugs.python.org/issue34706 Specifically in the case of a class that does not override its constructor signature inherited from object. These are Buck Evan @bukzor's changes cherrypicked from GH-9344. (cherry picked from commit 5b9ff7a) Co-authored-by: Gregory P. Smith <greg@krypto.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue34706
Specifically in the case of a class that does not override its constructor signature inherited from object.
Based on @bukzor's #9344 that I messed up the branch of. :)
https://bugs.python.org/issue34706