bpo-30266: support "= None" pattern in AbstractContextManager #1448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @JelleZijlstra, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ncoghlan, @berkerpeksag and @Yhg1s to be potential reviewers. |
ilevkivskyi approved these changes May 4, 2017
berkerpeksag requested changes May 4, 2017
Member
berkerpeksag left a comment
berkerpeksag left a comment There was a problem hiding this comment.
Could you please add a note to Misc/NEWS?
Member Author
| Done, thanks for the review. |
Member
| It looks like a fourth merge is required... |
Member
| Pinging @berkerpeksag -- is this now to your satisfaction? Could we get it in 3.6.3? (I.e. before Monday June 12.) |
Member
| This seems simple enough, I'm merging it. |
Member
| @Mariatta Can you help backporting this to 3.6? |
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request Jun 10, 2017
…ythonGH-1448) contextlib.AbstractContextManager now supports anti-registration by setting __enter__ = None or __exit__ = None, following the pattern introduced in bpo-25958.. (cherry picked from commit 57161aa)
Mariatta added a commit that referenced this pull request Jun 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.