Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
e5f4daa
apply Saimadhav's patch v3 (linenumber-text-widget-v3.diff)
taleinat Jun 12, 2019
5cda90d
updated into first working version
taleinat Jun 12, 2019
d35acd0
some refactoring
taleinat Jun 12, 2019
89feac0
fix integration with undo/redo
taleinat Jun 12, 2019
dd11796
give get_end a better name and a doc-string
taleinat Jun 12, 2019
62ce5db
fix buggy insertion of a delegator into the middle of the percolator
taleinat Jun 12, 2019
bd942da
fix bug where BaseSideBar.show_sidebar() ignored the given side
taleinat Jun 12, 2019
954d122
add a NEWS entry
taleinat Jun 12, 2019
5f21e7f
update line numbers immediately upon highlighting config changes
taleinat Jul 5, 2019
776aa4e
optimize and improve scrolling
taleinat Jul 5, 2019
86ebf06
add a separate configuration setting for line number colors
taleinat Jul 5, 2019
1cdfa27
remove double- and triple- click conversion to single clicks
taleinat Jul 5, 2019
083689e
replace hack to make font changes take effect immediately
taleinat Jul 5, 2019
8f02e7b
refactor and expand tests, also fixing test_delete
taleinat Jul 6, 2019
b7faf1f
attempt to fix tests failing on Linux
taleinat Jul 7, 2019
bbba1ea
remove sidebar text widget border on macOS
taleinat Jul 9, 2019
5cade34
mouse click and drag now select entire lines
taleinat Jul 9, 2019
351c205
fix layout when showing both line numbers and code context
taleinat Jul 9, 2019
7251403
fix test_toggle_linenumbering
taleinat Jul 9, 2019
335b78e
fix code context tests after pack->grid change
taleinat Jul 9, 2019
38cdf79
Merge remote-tracking branch 'origin/master' into pr_14030
terryjreedy Jul 10, 2019
76a1551
10. Make text_frame resizeable.
terryjreedy Jul 10, 2019
83220c0
Remove unneeded addition to config-extensions.def.
terryjreedy Jul 10, 2019
5ea1326
1. Skip warning for new theme elements.
terryjreedy Jul 10, 2019
857d536
Remane linenumbers.py to sidebar.py.
terryjreedy Jul 10, 2019
53abdb4
Rename test_linenumbers to test_sidebar, fix import.
terryjreedy Jul 10, 2019
3bccd46
rename test class
taleinat Jul 10, 2019
2c90d7a
forward double- and triple-clicks events as normal click events
taleinat Jul 10, 2019
0fad84f
line numbers off by default and set separately per window
taleinat Jul 10, 2019
c2fb8f9
configurable default for whether to show line numbers in new windows
taleinat Jul 10, 2019
5cd21f4
fix state of menu option when opening IDLE with line numbers shown
taleinat Jul 10, 2019
d246688
fix and improve show_sidebar() and hide_sidebar() and their tests
taleinat Jul 11, 2019
cc294e9
add tests for click and drag selections
taleinat Jul 11, 2019
bd8fc82
add a test for scrolling
taleinat Jul 11, 2019
f267df9
add an htest for drag-scrolling on the line numbers
taleinat Jul 11, 2019
7728110
fix string formatting in htest
taleinat Jul 11, 2019
8c13379
fix skipping warning for missing line number highlight config
taleinat Jul 11, 2019
8d2b924
fix skipping warning for missing line number highlight config
taleinat Jul 11, 2019
a90e9f7
fix click and drag selection
taleinat Jul 11, 2019
59a0011
Merge branch 'master' into bpo-17535/IDLE-line-numbers
taleinat Jul 17, 2019
ed0ebac
Merge branch 'master' into bpo-17535/IDLE-line-numbers
terryjreedy Jul 20, 2019
7c822b6
Move line numbers down a pixel.
terryjreedy Jul 20, 2019
46935c9
properly ensure correct Y-axis padding of the sidebar widget
taleinat Jul 22, 2019
6e937be
fix line numbers update upon font config changes
taleinat Jul 22, 2019
ab69da5
fix fragile tests in test_sidebar
taleinat Jul 22, 2019
60e1132
Update test_sidebar docstring.
terryjreedy Jul 23, 2019
da95809
Touchup docs.
terryjreedy Jul 23, 2019
bb2a08c
fix locally
terryjreedy Jul 23, 2019
4f01c1f
Merge branch 'bpo-17535/IDLE-line-numbers' of https://github.com/tale…
terryjreedy Jul 23, 2019
18dcbc9
more doc touch-ups: consistency, wording, typo
taleinat Jul 23, 2019
af4473b
add tests for font and color updates for line numbers
taleinat Jul 23, 2019
2a493ea
ensure font consistency in line numbers htest
taleinat Jul 23, 2019
86d420e
add "What's New" entries
taleinat Jul 23, 2019
27e741f
revert 3.9 "what's New" entry
taleinat Jul 23, 2019
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix integration with undo/redo
  • Loading branch information
taleinat committed Jun 12, 2019
commit 89feac0c20b44df1db6787ba9936ffe37fb47faa
9 changes: 7 additions & 2 deletions Lib/idlelib/linenumbers.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,10 +105,15 @@ def __init__(self, editwin):
self.sidebar_text.bind(event_name,
lambda event, event_name=event_name:
self.redirect_event(event, event_name))
self.end_line_delegator = EndLineDelegator(self.update_sidebar_text)
end = get_end(self.text)
self.update_sidebar_text(end)
self.editwin.per.insertfilter(self.end_line_delegator)

end_line_delegator = EndLineDelegator(self.update_sidebar_text)
# Insert the delegator after the undo delegator, so that line numbers
# are properly updated after undo and redo actions.
end_line_delegator.delegate = self.editwin.undo.delegate
self.editwin.undo.delegate = end_line_delegator

# self.state = idleConf.GetOption('extensions', 'LineNumber', 'visible',
# type='bool')
self.state = True # TODO: Read config
Expand Down