Skip to content

bpo-19903: IDLE: Change to inspect.signature for calltips #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

bpo-19903: IDLE: Change to inspect.signature for calltips #1382

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8c8d6aa
bpo-19903: Change to inspect.signature for calltips
louisom May 2, 2017
c5ef4d1
Revert object is not callable
louisom May 2, 2017
f1cf2c2
Fix first param trim condition
louisom May 3, 2017
837f88a
Revert test_non_callables
louisom May 3, 2017
a3bfdbd
Add built-in function test
louisom May 4, 2017
13172f1
Fix invalid method signature message
louisom May 4, 2017
b40056c
Fix re.sub compare string
louisom May 4, 2017
a9f1825
Fix callable signature
louisom May 4, 2017
8caf548
Revert unexpect bytes string
louisom May 5, 2017
a2b3829
Add AC argument positional explain and test
louisom May 5, 2017
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix first param trim condition
  • Loading branch information
@louisom
louisom committed May 3, 2017
commit f1cf2c2256821efebebd16fa2cd41d80ecc80c6c
6 changes: 2 additions & 4 deletions Lib/idlelib/calltips.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,8 @@ def get_argspec(ob):
argspec = "This function has an invalid method signature"
Copy link
Member

@terryjreedy terryjreedy May 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add _invalid_signature to global defs before function so can access for testing without repeating string.
return argspec

if (isinstance(ob, (type, types.MethodType)) or
isinstance(ob_call, types.MethodType)):
if argspec.startswith("(self,"):
argspec = _first_param.sub("", argspec)
if isinstance(ob, type):
argspec = _first_param.sub("", argspec)

lines = (textwrap.wrap(argspec, _MAX_COLS, subsequent_indent=_INDENT)
if len(argspec) > _MAX_COLS else [argspec] if argspec else [])
Expand Down
10 changes: 7 additions & 3 deletions Lib/idlelib/idle_test/test_calltips.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,11 +164,15 @@ def test_attribute_exception(self):
class NoCall:
def __getattr__(self, name):
raise BaseException
class Call(NoCall):
class CallA(NoCall):
def __call__(oui, a, b, c):
Copy link
Contributor Author

@louisom louisom May 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add corner case for first param not self
pass
class CallB(NoCall):
def __call__(self, ci):
pass
for meth, mtip in ((NoCall, default_tip), (Call, default_tip),
(NoCall(), ''), (Call(), '(ci)')):
for meth, mtip in ((NoCall, default_tip), (CallA, default_tip),
(NoCall(), ''), (CallA(), '(a, b, c)'),
(CallB(), '(ci)')):
self.assertEqual(signature(meth), mtip)


Copy link
Contributor Author

@louisom louisom May 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PEP8
Expand Down