Skip to content

gh-136170: Use earliest zinfo.header_offset as ZipFile.data_offset #136171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-136170: Use earliest zinfo.header_offset as ZipFile.data_offset #136171

wants to merge 1 commit into from

Conversation

danifus
Copy link
Contributor

@danifus danifus commented Jul 1, 2025 •
edited by bedevere-app bot
Loading

Use the earliest zinfo.header_offset for ZipFile.data_offset.

We already sort the zinfos by their header_offset in _RealGetContents so it is cheap to grab the zinfo with the lowest header_offset.

Happy to add a news entry if required (given that 3.14 which introduced ZipFile.data_offset hasn't been released yet?)
@bedevere-app bedevere-app bot mentioned this pull request Jul 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review
1 participant
@danifus