Skip to content

gh-101100: Fix sphinx warnings in whatsnew/3.9 #136163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jul 1, 2025

It used to be:

/Users/sobolev/Desktop/cpython/Doc/whatsnew/3.9.rst:426: WARNING: py:const reference target not found: fcntl.F_OFD_GETLK [ref.const] /Users/sobolev/Desktop/cpython/Doc/whatsnew/3.9.rst:426: WARNING: py:const reference target not found: fcntl.F_OFD_SETLK [ref.const] /Users/sobolev/Desktop/cpython/Doc/whatsnew/3.9.rst:426: WARNING: py:const reference target not found: fcntl.F_OFD_SETLKW [ref.const] /Users/sobolev/Desktop/cpython/Doc/whatsnew/3.9.rst:647: WARNING: py:attr reference target not found: random.Random.randbytes [ref.attr] /Users/sobolev/Desktop/cpython/Doc/whatsnew/3.9.rst:779: WARNING: py:func reference target not found: set.difference_update [ref.func] /Users/sobolev/Desktop/cpython/Doc/whatsnew/3.9.rst:1141: WARNING: py:func reference target not found: encodings.normalize_encoding [ref.func] 

I opened #136162 about the encodings part.

I had to use

:meth:`!set.difference_update` 

because stdtypes defines this method as frozenset.difference_update


📚 Documentation preview 📚: https://cpython-previews--136163.org.readthedocs.build/

@sobolevn sobolevn force-pushed the issue-101100-3.9 branch from 8fafbbf to 3054ebd Compare July 1, 2025 10:25
@rhettinger rhettinger removed their request for review July 4, 2025 00:59
@hugovk hugovk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 7, 2025
@hugovk hugovk merged commit 0a33221 into python:main Jul 7, 2025
29 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Jul 7, 2025
@miss-islington-app
Copy link

Thanks @sobolevn for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2025
(cherry picked from commit 0a33221) Co-authored-by: sobolevn <mail@sobolevn.me>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2025
(cherry picked from commit 0a33221) Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Jul 7, 2025

GH-136372 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 7, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jul 7, 2025

GH-136373 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 7, 2025
hugovk pushed a commit that referenced this pull request Jul 7, 2025
hugovk pushed a commit that referenced this pull request Jul 7, 2025
@@ -1139,7 +1139,7 @@ Changes in the Python API
(Contributed by Christian Heimes in :issue:`36384`).

* :func:`codecs.lookup` now normalizes the encoding name the same way as
:func:`encodings.normalize_encoding`, except that :func:`codecs.lookup` also
:func:`!encodings.normalize_encoding`, except that :func:`codecs.lookup` also
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be unnecessary with #136164, should I revert this there?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
3 participants