gh-108765: fix comment about macro definitions in _stat.c post GH-108854 #136027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| All commit authors signed the Contributor License Agreement. |
This comment was marked as resolved.
This comment was marked as resolved.
moreal changed the title _stat.c_stat.c to latest moreal force-pushed the fix-staled-comments branch from f0cfe18 to 1fe7601 Compare This comment was marked as resolved.
This comment was marked as resolved.
moreal force-pushed the fix-staled-comments branch from 1fe7601 to 88aeb4b Compare 
picnixz approved these changes Jun 27, 2025
picnixz changed the title _stat.c to latest_stat.c picnixz changed the title _stat.c_stat.c post GH-108854 
| @StanFromIreland In general, if the PR amends a previous PR, we can reuse the issue number of that PR (if there is one). |
picnixz added needs backport to 3.13 
| I was considering that, I hesitated for a few minutes before applying the label... My reasoning was, the issue was quite broad and would not add much, but I guess it is good to do so anyway. I will do so in the future! |
| For such PRs I usually add "post GH-*" in the title so that one can click on it as well. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 27, 2025
…pythonGH-108854 (pythonGH-136027) (cherry picked from commit 0141e7f) Co-authored-by: Lee Dogeon <dev.moreal@gmail.com>
| GH-136043 is a backport of this pull request to the 3.14 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 27, 2025
…pythonGH-108854 (pythonGH-136027) (cherry picked from commit 0141e7f) Co-authored-by: Lee Dogeon <dev.moreal@gmail.com>
| GH-136044 is a backport of this pull request to the 3.13 branch. |
picnixz pushed a commit that referenced this pull request Jun 27, 2025
picnixz pushed a commit that referenced this pull request Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This pull request only fixes a typo in the
_stat.cfile.Since #108854, the definitions of
S_ISDIR(),S_ISREG()andS_ISCHR(), as well as the part that includessys/stat.h, have moved fromInclude/pyport.htoInclude/fileutils.h. However the comment inModules/_stat.cstill refers toInclude/pyport.hso this pull request fixes it.As note, I didn't create and add an issue number because I think it is a trivial change. In the same context, I didn't think it was necessary to add NEWS as well.