gh-123681: Check NORMALIZE_CENTURY behavior at runtime; require C99 #136022
Conversation
…at the compile time It is needed to support cross-compiling. Remove macros Py_NORMALIZE_CENTURY and Py_STRFTIME_C99_SUPPORT.
encukou requested review from pganssle, abalkin, ericsnowcurrently, erlend-aasland and corona10 as code owners 
There was a problem hiding this comment.
If remove the C99 check in the C code, we should also remove _can_support_c99() in Lib/_pydatetime.py.
Look in #122272 for reasons for adding this check at first place.
| self.check_strftime_y2k('Y') | ||
| self.check_strftime_y2k('G') | ||
| | ||
| def test_strftime_y2k_c99(self): |
There was a problem hiding this comment.
Should not it be decorated with cpython_only?
There was a problem hiding this comment.
Good point! The meaning of cpython_only is not very clear.
This test might be usable for other implementations as well, so I think it's best for other implementations to skip the test if it doesn't work for them. IMO, cpython_only is best for things like bytecode details or sys.getsizeof.
But, that's just my opinion of course.
encukou added the 🔨 test-with-buildbots 
| 🤖 New build scheduled with the buildbot fleet by @encukou for commit a52be23 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136022%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot removed the 🔨 test-with-buildbots 
This is a continuation of #128444.
CPython requires C11, so all C99 features should work.
We might need workaround if a supported platform misbehaves (hence this PR -- I want to feed the buildbots). But, IMO, any workarounds for unsupported platforms best left to the respective forks.
Serhiy's runtime check for
normalize_centuryis left in; I don't know about the details there.test_strftime_y2kfails on embedded Linux #123681