[3.7] bpo-33110: Catch errors raised when running add_done_callback on already completed futures (GH-13141) #13508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ady completed futures (pythonGH-13141) Wrap the callback call within the `add_done_callback` function within concurrent.futures, in order to behave in an identical manner to callbacks added to a running future are triggered once it has completed. (cherry picked from commit 2a3a2ec) Co-authored-by: Sam Martin <ABitMoreDepth@users.noreply.github.com>
Contributor Author
| @ABitMoreDepth and @pitrou: Status check is done, and it's a success ✅ . |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Wrap the callback call within the
add_done_callbackfunction within concurrent.futures, in order to behave in an identical manner to callbacks added to a running future are triggered once it has completed.(cherry picked from commit 2a3a2ec)
Co-authored-by: Sam Martin ABitMoreDepth@users.noreply.github.com
https://bugs.python.org/issue33110