Skip to content

Conversation

freakboy3742
Copy link
Contributor

@freakboy3742 freakboy3742 commented May 26, 2025

#134652 introduced some modifications to support remote debugging; however the platform #defines (in particular the ones on L103, L138 and L170) was incorrectly including iOS in the usage, but not in the definition of the pid_to_task symbol.

The pid_to_task implementation depends on libproc.h and mach/mach-vm.h, which aren't available on iOS.

@freakboy3742
Copy link
Contributor Author

!buildbot iOS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit c5f5619 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134712%2Fmerge

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR
@freakboy3742 freakboy3742 requested a review from pablogsal May 26, 2025 12:15
@freakboy3742 freakboy3742 changed the title gh-94018: Correct Apple platform includes for iOS. gh-91048: Correct Apple platform includes for iOS. May 26, 2025
@freakboy3742 freakboy3742 enabled auto-merge (squash) May 26, 2025 12:23
@AA-Turner AA-Turner changed the title gh-91048: Correct Apple platform includes for iOS. gh-91048: Correct Apple platform includes for iOS May 26, 2025
@freakboy3742 freakboy3742 merged commit 965662e into python:main May 26, 2025
52 of 53 checks passed
@freakboy3742 freakboy3742 deleted the fix-apple-includes branch May 26, 2025 12:44
@miss-islington-app
Copy link

Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2025
…4712) Correct Apple platform includes for iOS. (cherry picked from commit 965662e) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
@bedevere-app
Copy link

bedevere-app bot commented May 26, 2025

GH-134714 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 26, 2025
freakboy3742 added a commit that referenced this pull request May 26, 2025
…#134714) Correct Apple platform includes for iOS. (cherry picked from commit 965662e) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants