Skip to content

gh-132002: Fix crash of ContextVar on unhashable str subtype #132003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sobolevn merged 2 commits into from
Apr 2, 2025
Merged

gh-132002: Fix crash of ContextVar on unhashable str subtype #132003

sobolevn merged 2 commits into from
Apr 2, 2025

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Apr 2, 2025 •
edited by bedevere-app bot
Loading

@sobolevn sobolevn requested a review from vstinner April 2, 2025 08:35
@sobolevn sobolevn requested a review from 1st1 as a code owner April 2, 2025 08:35
@bedevere-app bedevere-app bot mentioned this pull request Apr 2, 2025
Closed
@sobolevn sobolevn added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Apr 2, 2025
vstinner
vstinner reviewed Apr 2, 2025
View reviewed changes
vstinner
vstinner approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@sobolevn sobolevn merged commit ab2a3dd into python:main Apr 2, 2025
46 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Apr 2, 2025

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 2, 2025
@sobolevn @miss-islington
pythongh-132002: Fix crash of ContextVar on unhashable str subtype (
27c1e4b 
pythonGH-132003) (cherry picked from commit ab2a3dd) Co-authored-by: sobolevn <mail@sobolevn.me>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 2, 2025
@sobolevn @miss-islington
pythongh-132002: Fix crash of ContextVar on unhashable str subtype (
af14176 
pythonGH-132003) (cherry picked from commit ab2a3dd) Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app
Copy link

bedevere-app bot commented Apr 2, 2025

GH-132007 is a backport of this pull request to the 3.13 branch.
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 2, 2025
@bedevere-app
Copy link

bedevere-app bot commented Apr 2, 2025

GH-132008 is a backport of this pull request to the 3.12 branch.
@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Apr 2, 2025
@sobolevn
Copy link
Member Author

sobolevn commented Apr 2, 2025

Thanks for the quick review :)
@sobolevn sobolevn deleted the issue-132002 branch April 2, 2025 11:50
sobolevn added a commit that referenced this pull request Apr 2, 2025
@miss-islington @sobolevn
[3.12] gh-132002: Fix crash of ContextVar on unhashable str subty…
b3cf1f2 
…pe (GH-132003) (#132008) gh-132002: Fix crash of `ContextVar` on unhashable `str` subtype (GH-132003) (cherry picked from commit ab2a3dd) Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request Apr 2, 2025
@miss-islington @sobolevn
[3.13] gh-132002: Fix crash of ContextVar on unhashable str subty…
57e4f08 
…pe (GH-132003) (#132007) gh-132002: Fix crash of `ContextVar` on unhashable `str` subtype (GH-132003) (cherry picked from commit ab2a3dd) Co-authored-by: sobolevn <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@sobolevn @vstinner