gh-126835: Rename AST optimization related stuff after moving const folding to the peephole optimizier #131830
Conversation
WolframAlph requested review from a team, AA-Turner, Eclips4, ericsnowcurrently, erlend-aasland, ezio-melotti, hugovk and isidentical as code owners 
WolframAlph changed the title 
Misc/NEWS.d/next/Core_and_Builtins/2025-03-28-15-06-55.gh-issue-126835.IpcMTn.rst Show resolved Hide resolved
| I'm not sure about the name ast_process. Seems to nonspecific. I don't have a better idea at the moment though. |
| It does all kind of things. Optimizes format, removes docstrings, implements PEP 765, etc. I don't think there is good name for it to make it more specific. |
| @picnixz Maybe you have better suggestion how to name it? |
| I think "ast_process" is fine but otherwise, something with |
| Maybe |
There was a problem hiding this comment.
Yes, I think preprocess is better as it's before we compile (and compilers would call it a pre-processing step (e.g., C compilers would pre-process macros here and comments elimination; well optimization is not part of pre-processing and usually happens after but still before compilation I think?).
| All commit authors signed the Contributor License Agreement. |
| Hi @WolframAlph, are you still planning to work on this? We need to ship it soon since the feature freeze is approaching (May 6th). Regarding the naming—I believe |
| Hi sorry for the delay, Ive been super busy last weeks. I will finish this ASAP. |
WolframAlph force-pushed the rename-ast-opt branch from 58648da to 2d1bc6f Compare 
| @Eclips4 I've updated the PR. Please take a look. |
* origin/main: (111 commits) pythongh-91048: Add filename and line number to external inspection routines (pythonGH-133385) pythongh-131178: Add tests for `ast` command-line interface (python#133329) Regenerate pcbuild.sln in Visual Studio 2022 (python#133394) pythongh-133042: disable HACL* HMAC on Emscripten (python#133064) pythongh-133351: Fix remote PDB's multi-line block tab completion (python#133387) pythongh-109700: Improve stress tests for interpreter creation (pythonGH-109946) pythongh-81793: Skip tests for os.link() to symlink on Android (pythonGH-133388) pythongh-126835: Rename `ast_opt.c` to `ast_preprocess.c` and related stuff after moving const folding to the peephole optimizier (python#131830) pythongh-91048: Relax test_async_global_awaited_by to fix flakyness (python#133368) pythongh-132457: make staticmethod and classmethod generic (python#132460) pythongh-132805: annotationlib: Fix handling of non-constant values in FORWARDREF (python#132812) pythongh-132426: Add get_annotate_from_class_namespace replacing get_annotate_function (python#132490) pythongh-81793: Always call linkat() from os.link(), if available (pythonGH-132517) pythongh-122559: Synchronize C and Python implementation of the io module about pickling (pythonGH-122628) pythongh-69605: Add PyREPL import autocomplete feature to 'What's New' (python#133358) bpo-44172: Keep reference to original window in curses subwindow objects (pythonGH-26226) pythonGH-133231: Changes to executor management to support proposed `sys._jit` module (pythonGH-133287) pythongh-133363: Fix Cmd completion for lines beginning with `! ` (python#133364) pythongh-132983: Introduce `_zstd` bindings module (pythonGH-133027) pythonGH-91048: Add utils for printing the call stack for asyncio tasks (python#133284) ...
… stuff after moving const folding to the peephole optimizier (python#131830)
5 participants
Uh oh!
There was an error while loading. Please reload this page.