Skip to content

bpo-6584: Add a BadGzipFile exception to the gzip module #13022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 13, 2019
Merged

bpo-6584: Add a BadGzipFile exception to the gzip module #13022

merged 2 commits into from
May 13, 2019

Conversation

@ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Apr 30, 2019 •
edited by bedevere-bot
Loading

Co-Authored-By: Filip Gruszczyński gruszczy@gmail.com
Co-Authored-By: Michele Orrù maker@tumbolandia.net

https://bugs.python.org/issue6584
@ZackerySpytz @gruszczy @mmaker
bpo-6584: Add a BadGzipFile exception to the gzip module
aef8e13 
Co-Authored-By: Filip Gruszczyński <gruszczy@gmail.com> Co-Authored-By: Michele Orrù <maker@tumbolandia.net>
@ZackerySpytz
Copy link
Contributor Author

ZackerySpytz commented Apr 30, 2019

EOFError can be raised in some cases in the gzip module, and this was added to match with
bz2 and lzma (https://bugs.python.org/issue1159051 / cc0172c). I don't think these cases should be replaced with BadGzipFile.
@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented May 2, 2019

It should be documented clearly that BadGzipFile is not the only exception raised by corrupted gzip files. EOFError and zlib.error also can be raised.
@ZackerySpytz
Copy link
Contributor Author

ZackerySpytz commented May 2, 2019

@serhiy-storchaka Thank you for your comment, Serhiy! EOFError and zlib.error are now mentioned in the gzip documentation. Please take a look.
@csabella
Copy link
Contributor

csabella commented May 13, 2019

@serhiy-storchaka, is this ready to be merged? Thanks!
@serhiy-storchaka serhiy-storchaka merged commit cf599f6 into python:master May 13, 2019
@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented May 13, 2019

It was ready to merged. I just gave a chance to other core devs to make a review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants

@ZackerySpytz @serhiy-storchaka @csabella @auvipy @the-knights-who-say-ni @bedevere-bot