-
- Notifications
You must be signed in to change notification settings - Fork 33.7k
gh-128505: Expose an interface to sqlite3_file_control #128507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hashbrowncipher wants to merge 15 commits into python:main Choose a base branch from hashbrowncipher:sqlite3_file_control
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits Select commit Hold shift + click to select a range
e32c372 sqlite3_file_control
hashbrowncipher 3f9c1e2 sqlite3_file_control
hashbrowncipher f9eb73d sqlite3_file_control
hashbrowncipher dc60055 sqlite3_file_control
hashbrowncipher 4867672 sqlite3_file_control
hashbrowncipher 4bcb82c sqlite3_file_control
hashbrowncipher c42bbd5 change arg
hashbrowncipher 466401c remove unsupported opcodes
hashbrowncipher cc3bed9 update docstring
hashbrowncipher 773dc5f add reference docs
hashbrowncipher e6d299b Pull in main
erlend-aasland bd2a2a9 gh-129928: Rework sqlite3 error helpers
erlend-aasland b376f84 Merge remote-tracking branch 'erlend-aasland/sqlite/set-error' into s…
hashbrowncipher b17f832 use set_error_from_code
hashbrowncipher 8bb3c57 fix test
hashbrowncipher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions 3 Misc/NEWS.d/next/Library/2025-01-05-00-55-41.gh-issue-128505.Nf5FY2.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| sqlite Connection objects now expose a method | ||
| :meth:`sqlite3.Connection.file_control`, which is a thin wrapper for | ||
| `sqlite3_file_control <https://www.sqlite.org/c3ref/file_control.html>`_. | ||
hashbrowncipher marked this conversation as resolved. Show resolved Hide resolved | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
InternalErrorsounds suspicious. What's the underlying SQLite error code?SQLITE_MISUSE?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the failed test run, the full exception is
sqlite3.InternalError: unknown operation, which appears to correspond toSQLITE_NOTFOUND.