gh-128384: Use contextvar for catch_warnings() #128463
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
By default, inherit the context from the thread calling `Thread.start()`.
Expose the mutex from _warnings.c and hold it when mutating the filters list or the filters version.
Member Author
| Implemented in GH-130010. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This changes
warnings.catch_warnings()to use a contextvar for the new list of filters. Ifcatch_warningsis not used, the list of filters is the module globalwarnings.filters. When the context manager is active, the effective list of filters iswarnings.get_context()._filters.This change is on top of two other unmerged PRs:
📚 Documentation preview 📚: https://cpython-previews--128463.org.readthedocs.build/