gh-126980: Fix bytearray.__buffer__ crash on PyBUF_{READ,WRITE} #126981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
vstinner reviewed Nov 19, 2024
Member
I don't think I wrote |
Co-authored-by: Victor Stinner <vstinner@python.org>
skirpichev approved these changes Nov 19, 2024
vstinner approved these changes Nov 19, 2024
Member Author
| This needs backport to 3.13: https://github.com/python/cpython/blob/3.13/Objects/abstract.c#L770-L774 |
| Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
| Sorry, @sobolevn, I could not cleanly backport this to |
Member Author
| Will do a manual one. |
sobolevn added a commit to sobolevn/cpython that referenced this pull request Nov 19, 2024
…EAD,WRITE}` (pythonGH-126981) (cherry picked from commit 3932e1d) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Victor Stinner <vstinner@python.org>
sobolevn added a commit to sobolevn/cpython that referenced this pull request Nov 19, 2024
…EAD,WRITE}` (pythonGH-126981) (cherry picked from commit 3932e1d) Co-authored-by: sobolevn <mail@sobolevn.me> Co-authored-by: Victor Stinner <vstinner@python.org>
| GH-127023 is a backport of this pull request to the 3.13 branch. |
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
…TE}` (python#126981) Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Related #114802
@JelleZijlstra, since you are
__buffer__PEP author, could you please take a look? :)bytearray().__buffer__(256)crashes #126980