Skip to content

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Oct 20, 2024

pickle.Pickler.persistent_id and pickle.Unpickler.persistent_load can again be overridden as instance attributes.

…pickler and unpickler pickle.Pickler.persistent_id and pickle.Unpickler.persistent_load can again be overridden as instance attributes.
@rruuaanng
Copy link
Contributor

For those who cannot pass CI, you're not alone. Maybe we should find solutions together.
#125745

Copy link
Contributor

@rruuaanng rruuaanng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's look goods :)

@serhiy-storchaka serhiy-storchaka merged commit 223d3dc into python:main Nov 7, 2024
39 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the pickler-unpickler-attrs branch November 7, 2024 06:53
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 7, 2024
…pickler and unpickler (pythonGH-125752) pickle.Pickler.persistent_id and pickle.Unpickler.persistent_load can again be overridden as instance attributes. (cherry picked from commit 223d3dc) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 7, 2024

GH-126528 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 7, 2024
serhiy-storchaka added a commit that referenced this pull request Nov 7, 2024
… pickler and unpickler (GH-125752) (GH-126528) pickle.Pickler.persistent_id and pickle.Unpickler.persistent_load can again be overridden as instance attributes. (cherry picked from commit 223d3dc) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
…pickler and unpickler (pythonGH-125752) pickle.Pickler.persistent_id and pickle.Unpickler.persistent_load can again be overridden as instance attributes.
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
…pickler and unpickler (pythonGH-125752) pickle.Pickler.persistent_id and pickle.Unpickler.persistent_load can again be overridden as instance attributes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants