gh-123923: Defer refcounting for f_executable in _PyInterpreterFrame #123924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…terFrame` Use a `_PyStackRef` and defer the reference to `f_executable` when possible. This avoids some reference count contention in the common case of executing the same code object from multiple threads concurrently in the free-threaded build.
graingert reviewed Sep 10, 2024
colesbury requested review from Fidget-Spinner and markshannon as code owners Member
Fidget-Spinner left a comment
Fidget-Spinner left a comment There was a problem hiding this comment.
I trust that you've run this with refleak tests? When I attempted this, there were a ton of refleaks.
Also one question. The rest looks good to me!
colesbury added the 🔨 test-with-refleak-buildbots 
| 🤖 New build scheduled with the buildbot fleet by @colesbury for commit 9e7691a 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot removed the 🔨 test-with-refleak-buildbots 
Fidget-Spinner approved these changes Sep 11, 2024
Member
Fidget-Spinner left a comment
Fidget-Spinner left a comment There was a problem hiding this comment.
I think this makes sense now. Just one comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Use a
_PyStackRefand defer the reference tof_executablewhen possible. This avoids some reference count contention in the common case of executing the same code object from multiple threads concurrently in the free-threaded build._PyInterpreterFramefields #123923