gh-123504: Fix regression in _tkinter initializer

[ZeroIntensity]

cc @serhiy-storchaka

• Issue: _tkinter leaks type references on initialization #123504

[ZeroIntensity]

(@encukou, this needs skip news.)

[picnixz]

You can @ either me or @Eclips4 for skip news requests since we are triagers, or we'll just see whether this is needed or not when we'll look at the PR.

[ZeroIntensity]

You can @ either me or @Eclips4 for skip news requests since we are triagers

I would, but Petr specifically requested that I ping him for label changes (he's "mentoring" me for triage membership).

[ZeroIntensity]

Does that look alright?

[picnixz]

Sounds good! If I were to nitpick I would have (in the previous PR that I wasn't able to comment since it was merged before):

• Py_UNUSED(module) in the module_traverse signature
• Py_UNUSED(mod) in the module_clear signature
• (void)module_clear((PyObject *)mod); in module_free
• Renamed the functions to _tkintermodule_{clear,traverse,free}.

You could do those cosmetic changes if you want but otherwise it's fine.

[ZeroIntensity]

I'm going to leave the names as is, we can change them if we decide to migrate tkinter over to PEP 489

[vstinner]

LGTM.

[serhiy-storchaka]

LGTM.