bpo-34160: Update news entry for XML order attributes #12335
Merged
+6 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dfrojas changed the title 
dfrojas force-pushed the newsentry-xmlattributeorder branch from e75bce7 to 03f8ddb Compare 
vstinner reviewed Mar 15, 2019
Doc/whatsnew/3.8.rst Outdated
| changing the selection. (Contributed by Serhiy Storchaka in :issue:`31508`.) | ||
| | ||
| * The :meth:`writexml`, :meth:`toxml` and :meth:`toprettyxml` methods | ||
| now preserves the attribute order specified by the user. |
Member
There was a problem hiding this comment.
please list which modules have been modified. Something like: "xml.dom.minidom, xml.etree, ...: The ... methods ...".
vadmium reviewed Mar 15, 2019
Doc/whatsnew/3.8.rst Outdated
| changing the selection. (Contributed by Serhiy Storchaka in :issue:`31508`.) | ||
| | ||
| * The :meth:`writexml`, :meth:`toxml` and :meth:`toprettyxml` methods | ||
| now preserves the attribute order specified by the user. |
Member
There was a problem hiding this comment.
Plural verb form: “The . . . methods now preserve the . . .”
| @rhettinger: Please replace |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Update news entry for change of Python API which preserves the XML order attributes.
https://bugs.python.org/issue34160