gh-122334: Fix test_embed failure when missing _ssl module #122630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
neonene changed the title 
| Could anyone trigger the buildbots? Thanks. |
Wulian233 reviewed Aug 2, 2024
Co-authored-by: Wulian233 <1055917385@qq.com>
| !buildbot x86-64 MacOS Intel ASAN NoGIL |
| !buildbot AMD64 RHEL7 |
encukou added skip news needs backport to 3.13 | Whoa, that's a lot more buildbots than what I asked for. I filed python/buildmaster-config#509 |
encukou approved these changes Aug 3, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 3, 2024
…honGH-122630) (cherry picked from commit 50b3603) Co-authored-by: neonene <53406459+neonene@users.noreply.github.com> Co-authored-by: Wulian233 <1055917385@qq.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 3, 2024
…honGH-122630) (cherry picked from commit 50b3603) Co-authored-by: neonene <53406459+neonene@users.noreply.github.com> Co-authored-by: Wulian233 <1055917385@qq.com>
| GH-122647 is a backport of this pull request to the 3.13 branch. |
| GH-122648 is a backport of this pull request to the 3.12 branch. |
| Thank you. |
brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull request Aug 7, 2024
…honGH-122630) Co-authored-by: Wulian233 <1055917385@qq.com>
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
…honGH-122630) Co-authored-by: Wulian233 <1055917385@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes the
test_embedfailure in some buildbots introduced by 9fc1c99 (gh-122481).If checking the
_sslmodule is not enough, I'll make the test more generic using_testinternalcapi.This patch should be backportable to both 3.13 and 3.12.
cc @kumaraditya303 @ericsnowcurrently: Sorry for the trouble.