bpo-36251: Fix format strings used in match_repr() and stdprinter_repr() #12252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The `mark`s are Py_ssize_t, not `int`. The correct format specifier for that is %zd.
The appropriate format specifier to print a pointer as 0x.... is %p.
serhiy-storchaka approved these changes Mar 10, 2019
| Thanks @sth for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
| GH-12263 is a backport of this pull request to the 3.7 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 10, 2019
…r(). (pythonGH-12252) (cherry picked from commit 8b91eda) Co-authored-by: sth <sth.dev@tejp.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In
match_repr(), themarks arePy_ssize_t, notint.In
stdprinter_repr(), the argument is a pointer and the correct format specifier for that is%p(this includes the 0x prefix).For reference: The docs for PyUnicode_FromFormat
https://bugs.python.org/issue36251