Skip to content

bpo-36250: ignore ValueError from signal in non-main thread #12251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 9, 2019
Merged

bpo-36250: ignore ValueError from signal in non-main thread #12251

merged 2 commits into from
Sep 9, 2019

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Mar 9, 2019 •
edited by bedevere-bot
Loading

zware
zware requested changes Mar 10, 2019
View reviewed changes
@bedevere-bot
Copy link

bedevere-bot commented Mar 10, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
@zware @blueyed
Apply suggestions from code review
443fe5a 
Co-Authored-By: blueyed <github@thequod.de>
@blueyed
Copy link
Contributor Author

blueyed commented Mar 10, 2019

I have made the requested changes; please review again.
@bedevere-bot
Copy link

bedevere-bot commented Mar 10, 2019

Thanks for making the requested changes!

@zware: please review the changes made to this pull request.
@zware zware merged commit 8d64bfa into python:master Sep 9, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Sep 9, 2019

Thanks @blueyed for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2019
@blueyed @miss-islington
bpo-36250: ignore ValueError from signal in non-main thread (pythonGH…
536d84b 
…-12251) Authored-By: blueyed <github@thequod.de> (cherry picked from commit 8d64bfa) Co-authored-by: Daniel Hahler <github@thequod.de>
@bedevere-bot
Copy link

bedevere-bot commented Sep 9, 2019

GH-15752 is a backport of this pull request to the 3.8 branch.
@zware
Copy link
Member

zware commented Sep 9, 2019

Thanks for the patch, and sorry for the delay in my re-review!
miss-islington added a commit that referenced this pull request Sep 9, 2019
@miss-islington @blueyed
bpo-36250: ignore ValueError from signal in non-main thread (GH-12251)
87a5a33 
Authored-By: blueyed <github@thequod.de> (cherry picked from commit 8d64bfa) Co-authored-by: Daniel Hahler <github@thequod.de>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@blueyed @lisroach
bpo-36250: ignore ValueError from signal in non-main thread (pythonGH…
4fb9544 
…-12251) Authored-By: blueyed <github@thequod.de>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@blueyed @DinoV
bpo-36250: ignore ValueError from signal in non-main thread (pythonGH…
6869989 
…-12251) Authored-By: blueyed <github@thequod.de>
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@blueyed @websurfer5
bpo-36250: ignore ValueError from signal in non-main thread (pythonGH…
b423dce 
…-12251) Authored-By: blueyed <github@thequod.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants

@blueyed @bedevere-bot @miss-islington @zware @the-knights-who-say-ni