gh-99180: Make StackSummary.should_show_carets private #119554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pablogsal approved these changes May 25, 2024
| Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2024
…nGH-119554) (cherry picked from commit 4b7eb32) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
| GH-119556 is a backport of this pull request to the 3.13 branch. |
AlexWaygood added a commit that referenced this pull request May 25, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
See https://github.com/python/cpython/pull/112670/files#r1613952301. This wasn't meant to be a public API; prefixing the name with an underscore means it won't show up in
help()or autocompletion suggestions.returnand simple assignment statements #99180