Skip to content

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 22, 2024

@erlend-aasland
Copy link
Contributor Author

@ericsnowcurrently: this works nice for a single test run, but obviously fails if we're running ref-leak tests (the reload reinitializes the singletons in the global state).

@erlend-aasland
Copy link
Contributor Author

One way to fix reloading is to use an initialization guard.

@tonybaloney
Copy link
Contributor

thank you for doing this!

Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ncoghlan
Copy link
Contributor

@ericsnowcurrently @erlend-aasland Are we sure this won't segfault in the case I described in #117398 (comment) ? (acquire a capsule reference, reload the module, use the capsule with the reloaded module)

The addition of the no_rerun guard on the C API test case makes me more concerned about that risk than I already was.

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented May 23, 2024

This is an incomplete first step of a series of multiple PRs. Eric and I propose to handle the encapsulated C API last. The scenario you describe will probably segfault for now.

@erlend-aasland
Copy link
Contributor Author

FTR, the test guard was added because running with test -R : leaks.

@erlend-aasland
Copy link
Contributor Author

Actually, the scenario you are describing is what happens when you do a ref-leak run of the C API test: the _testcapimodule reuses the pointer to the encapsulted C API, but the _datetime module is reloaded (and its exec function is run) every time. I didn't check coverage (yet), but so far this only causes leaks.

@ericsnowcurrently ericsnowcurrently marked this pull request as ready for review May 27, 2024 19:56
@ericsnowcurrently ericsnowcurrently merged commit 3e8b609 into python:main May 27, 2024
@miss-islington-app

This comment was marked as outdated.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 27, 2024
This is minimal support. Subinterpreters are not supported yet. That will be addressed in a later change. (cherry picked from commit 3e8b609) Co-authored-by: Erlend E. Aasland <erlend@python.org> Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented May 27, 2024

GH-119636 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 27, 2024
@erlend-aasland erlend-aasland deleted the isolate-datetime/multiphase-init branch May 27, 2024 22:04
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD 3.13 has failed when building commit d58ebf0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1491/builds/93) and take a look at the build logs.
  4. Check if the failure is related to this commit (d58ebf0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1491/builds/93

Failed tests:

  • test_datetime
  • test.test_concurrent_futures.test_process_pool

Failed subtests:

  • test_utc_alias - test.datetimetester.TestModule_Fast.test_utc_alias

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/buildbot/buildarea/3.13.ware-freebsd/build/Lib/threading.py", line 1039, in _bootstrap_inner self.run() ~~~~~~~~^^ File "/buildbot/buildarea/3.13.ware-freebsd/build/Lib/concurrent/futures/process.py", line 354, in run p = self.processes.pop(result_item.exit_pid) KeyError: 26371 Traceback (most recent call last): File "/buildbot/buildarea/3.13.ware-freebsd/build/Lib/multiprocessing/forkserver.py", line 277, in main code = _serve_one(child_r, fds, unused_fds, old_handlers) File "/buildbot/buildarea/3.13.ware-freebsd/build/Lib/multiprocessing/forkserver.py", line 317, in _serve_one code = spawn._main(child_r, parent_sentinel) File "/buildbot/buildarea/3.13.ware-freebsd/build/Lib/multiprocessing/spawn.py", line 132, in _main self = reduction.pickle.load(from_parent) File "/buildbot/buildarea/3.13.ware-freebsd/build/Lib/multiprocessing/synchronize.py", line 115, in __setstate__ self._semlock = _multiprocessing.SemLock._rebuild(*state) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^ FileNotFoundError: [Errno 2] No such file or directory Timeout (0:20:00)! Thread 0x000000083361b300 (most recent call first): File "/buildbot/buildarea/3.13.ware-freebsd/build/Lib/threading.py", line 359 in wait File "/buildbot/buildarea/3.13.ware-freebsd/build/Lib/multiprocessing/queues.py", line 249 in _feed File "/buildbot/buildarea/3.13.ware-freebsd/build/Lib/threading.py", line 990 in run File "/buildbot/buildarea/3.13.ware-freebsd/build/Lib/threading.py", line 1039 in _bootstrap_inner File "/buildbot/buildarea/3.13.ware-freebsd/build/Lib/threading.py", line 1010 in _bootstrap Traceback (most recent call last): File "/buildbot/buildarea/3.13.ware-freebsd/build/Lib/test/datetimetester.py", line 98, in test_utc_alias self.assertIs(UTC, timezone.utc) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ AssertionError: datetime.timezone(datetime.timedelta(0)) is not datetime.timezone.utc 
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86-64 MacOS Intel NoGIL 3.13 has failed when building commit d58ebf0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1449/builds/81) and take a look at the build logs.
  4. Check if the failure is related to this commit (d58ebf0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1449/builds/81

Failed tests:

  • test_datetime

Failed subtests:

  • test_utc_alias - test.datetimetester.TestModule_Fast.test_utc_alias

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/Users/ec2-user/buildbot/buildarea/3.13.itamaro-macos-intel-aws.nogil/build/Lib/test/datetimetester.py", line 98, in test_utc_alias self.assertIs(UTC, timezone.utc) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ AssertionError: datetime.timezone(datetime.timedelta(0)) is not datetime.timezone.utc 
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.13 has failed when building commit d58ebf0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1441/builds/82) and take a look at the build logs.
  4. Check if the failure is related to this commit (d58ebf0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1441/builds/82

Failed tests:

  • test_datetime

Failed subtests:

  • test_utc_alias - test.datetimetester.TestModule_Fast.test_utc_alias

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/root/buildarea/3.13.angelico-debian-amd64/build/Lib/test/datetimetester.py", line 98, in test_utc_alias self.assertIs(UTC, timezone.utc) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ AssertionError: datetime.timezone(datetime.timedelta(0)) is not datetime.timezone.utc 
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot wasm32-wasi 3.13 has failed when building commit d58ebf0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1502/builds/83) and take a look at the build logs.
  4. Check if the failure is related to this commit (d58ebf0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1502/builds/83

Failed tests:

  • test_datetime

Failed subtests:

  • test_utc_alias - test.datetimetester.TestModule_Fast.test_utc_alias

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/Lib/test/datetimetester.py", line 98, in test_utc_alias self.assertIs(UTC, timezone.utc) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ AssertionError: datetime.timezone(datetime.timedelta(0)) is not datetime.timezone.utc 
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows10 3.13 has failed when building commit d58ebf0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1501/builds/78) and take a look at the build logs.
  4. Check if the failure is related to this commit (d58ebf0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1501/builds/78

Failed tests:

  • test_datetime

Failed subtests:

  • test_utc_alias - test.datetimetester.TestModule_Fast.test_utc_alias

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "D:\buildarea\3.13.bolen-windows10\build\Lib\test\datetimetester.py", line 98, in test_utc_alias self.assertIs(UTC, timezone.utc) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ AssertionError: datetime.timezone(datetime.timedelta(0)) is not datetime.timezone.utc 
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL7 LTO 3.13 has failed when building commit d58ebf0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1505/builds/71) and take a look at the build logs.
  4. Check if the failure is related to this commit (d58ebf0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1505/builds/71

Failed tests:

  • test_datetime

Failed subtests:

  • test_utc_alias - test.datetimetester.TestModule_Fast.test_utc_alias

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/buildbot/buildarea/3.13.cstratak-RHEL7-x86_64.lto/build/Lib/test/datetimetester.py", line 98, in test_utc_alias self.assertIs(UTC, timezone.utc) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ AssertionError: datetime.timezone(datetime.timedelta(0)) is not datetime.timezone.utc 
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL7 LTO 3.13 has failed when building commit d58ebf0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1390/builds/68) and take a look at the build logs.
  4. Check if the failure is related to this commit (d58ebf0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1390/builds/68

Failed tests:

  • test_datetime

Failed subtests:

  • test_utc_alias - test.datetimetester.TestModule_Fast.test_utc_alias

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/dje/cpython-buildarea/3.13.edelsohn-rhel-z.lto/build/Lib/test/datetimetester.py", line 98, in test_utc_alias self.assertIs(UTC, timezone.utc) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ AssertionError: datetime.timezone(datetime.timedelta(0)) is not datetime.timezone.utc 
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 LTO 3.13 has failed when building commit d58ebf0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1458/builds/67) and take a look at the build logs.
  4. Check if the failure is related to this commit (d58ebf0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1458/builds/67

Failed tests:

  • test_datetime

Failed subtests:

  • test_utc_alias - test.datetimetester.TestModule_Fast.test_utc_alias

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/dje/cpython-buildarea/3.13.edelsohn-rhel8-z.lto/build/Lib/test/datetimetester.py", line 98, in test_utc_alias self.assertIs(UTC, timezone.utc) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ AssertionError: datetime.timezone(datetime.timedelta(0)) is not datetime.timezone.utc 
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL8 LTO + PGO 3.13 has failed when building commit d58ebf0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1503/builds/63) and take a look at the build logs.
  4. Check if the failure is related to this commit (d58ebf0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1503/builds/63

Failed tests:

  • test_datetime

Failed subtests:

  • test_utc_alias - test.datetimetester.TestModule_Fast.test_utc_alias

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-x86_64.lto-pgo/build/Lib/test/datetimetester.py", line 98, in test_utc_alias self.assertIs(UTC, timezone.utc) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ AssertionError: datetime.timezone(datetime.timedelta(0)) is not datetime.timezone.utc 
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL8 FIPS Only Blake2 Builtin Hash 3.13 has failed when building commit d58ebf0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1455/builds/77) and take a look at the build logs.
  4. Check if the failure is related to this commit (d58ebf0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1455/builds/77

Failed tests:

  • test_datetime

Failed subtests:

  • test_utc_alias - test.datetimetester.TestModule_Fast.test_utc_alias

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/test/datetimetester.py", line 98, in test_utc_alias self.assertIs(UTC, timezone.utc) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ AssertionError: datetime.timezone(datetime.timedelta(0)) is not datetime.timezone.utc 
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL8 LTO 3.13 has failed when building commit d58ebf0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1383/builds/64) and take a look at the build logs.
  4. Check if the failure is related to this commit (d58ebf0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1383/builds/64

Failed tests:

  • test_datetime

Failed subtests:

  • test_utc_alias - test.datetimetester.TestModule_Fast.test_utc_alias

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-x86_64.lto/build/Lib/test/datetimetester.py", line 98, in test_utc_alias self.assertIs(UTC, timezone.utc) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ AssertionError: datetime.timezone(datetime.timedelta(0)) is not datetime.timezone.utc 
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu Shared 3.13 has failed when building commit d58ebf0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1450/builds/73) and take a look at the build logs.
  4. Check if the failure is related to this commit (d58ebf0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1450/builds/73

Failed tests:

  • test_datetime

Failed subtests:

  • test_utc_alias - test.datetimetester.TestModule_Fast.test_utc_alias

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/srv/buildbot/buildarea/3.13.bolen-ubuntu/build/Lib/test/datetimetester.py", line 98, in test_utc_alias self.assertIs(UTC, timezone.utc) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ AssertionError: datetime.timezone(datetime.timedelta(0)) is not datetime.timezone.utc 
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Fedora Stable 3.13 has failed when building commit d58ebf0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1498/builds/53) and take a look at the build logs.
  4. Check if the failure is related to this commit (d58ebf0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1498/builds/53

Failed tests:

  • test_datetime

Failed subtests:

  • test_utc_alias - test.datetimetester.TestModule_Fast.test_utc_alias

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-x86_64/build/Lib/test/datetimetester.py", line 98, in test_utc_alias self.assertIs(UTC, timezone.utc) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ AssertionError: datetime.timezone(datetime.timedelta(0)) is not datetime.timezone.utc 
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 MacOS M1 NoGIL 3.13 has failed when building commit d58ebf0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1408/builds/66) and take a look at the build logs.
  4. Check if the failure is related to this commit (d58ebf0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1408/builds/66

Failed tests:

  • test_datetime

Failed subtests:

  • test_utc_alias - test.datetimetester.TestModule_Fast.test_utc_alias

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/Users/ec2-user/buildbot/buildarea/3.13.itamaro-macos-arm64-aws.macos-with-brew.nogil/build/Lib/test/datetimetester.py", line 98, in test_utc_alias self.assertIs(UTC, timezone.utc) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ AssertionError: datetime.timezone(datetime.timedelta(0)) is not datetime.timezone.utc 
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 RHEL8 LTO + PGO 3.13 has failed when building commit d58ebf0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1451/builds/60) and take a look at the build logs.
  4. Check if the failure is related to this commit (d58ebf0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1451/builds/60

Failed tests:

  • test_datetime

Failed subtests:

  • test_utc_alias - test.datetimetester.TestModule_Fast.test_utc_alias

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-aarch64.lto-pgo/build/Lib/test/datetimetester.py", line 98, in test_utc_alias self.assertIs(UTC, timezone.utc) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ AssertionError: datetime.timezone(datetime.timedelta(0)) is not datetime.timezone.utc 
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 RHEL8 LTO 3.13 has failed when building commit d58ebf0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1393/builds/60) and take a look at the build logs.
  4. Check if the failure is related to this commit (d58ebf0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1393/builds/60

Failed tests:

  • test_datetime

Failed subtests:

  • test_utc_alias - test.datetimetester.TestModule_Fast.test_utc_alias

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/buildbot/buildarea/3.13.cstratak-RHEL8-aarch64.lto/build/Lib/test/datetimetester.py", line 98, in test_utc_alias self.assertIs(UTC, timezone.utc) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ AssertionError: datetime.timezone(datetime.timedelta(0)) is not datetime.timezone.utc 
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Fedora Stable Clang 3.13 has failed when building commit d58ebf0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1479/builds/53) and take a look at the build logs.
  4. Check if the failure is related to this commit (d58ebf0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1479/builds/53

Failed tests:

  • test_datetime

Failed subtests:

  • test_utc_alias - test.datetimetester.TestModule_Fast.test_utc_alias

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-x86_64.clang/build/Lib/test/datetimetester.py", line 98, in test_utc_alias self.assertIs(UTC, timezone.utc) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ AssertionError: datetime.timezone(datetime.timedelta(0)) is not datetime.timezone.utc 
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable 3.13 has failed when building commit d58ebf0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1506/builds/64) and take a look at the build logs.
  4. Check if the failure is related to this commit (d58ebf0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1506/builds/64

Failed tests:

  • test_datetime

Failed subtests:

  • test_utc_alias - test.datetimetester.TestModule_Fast.test_utc_alias

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64/build/Lib/test/datetimetester.py", line 98, in test_utc_alias self.assertIs(UTC, timezone.utc) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ AssertionError: datetime.timezone(datetime.timedelta(0)) is not datetime.timezone.utc 
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable Clang 3.13 has failed when building commit d58ebf0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1456/builds/65) and take a look at the build logs.
  4. Check if the failure is related to this commit (d58ebf0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1456/builds/65

Failed tests:

  • test_datetime

Failed subtests:

  • test_utc_alias - test.datetimetester.TestModule_Fast.test_utc_alias

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.clang/build/Lib/test/datetimetester.py", line 98, in test_utc_alias self.assertIs(UTC, timezone.utc) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ AssertionError: datetime.timezone(datetime.timedelta(0)) is not datetime.timezone.utc 
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Clang 3.13 has failed when building commit d58ebf0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1476/builds/54) and take a look at the build logs.
  4. Check if the failure is related to this commit (d58ebf0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1476/builds/54

Failed tests:

  • test_datetime

Failed subtests:

  • test_utc_alias - test.datetimetester.TestModule_Fast.test_utc_alias

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/dje/cpython-buildarea/3.13.edelsohn-fedora-z.clang/build/Lib/test/datetimetester.py", line 98, in test_utc_alias self.assertIs(UTC, timezone.utc) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ AssertionError: datetime.timezone(datetime.timedelta(0)) is not datetime.timezone.utc 
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request May 28, 2024
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Fedora Stable LTO + PGO 3.13 has failed when building commit d58ebf0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1426/builds/55) and take a look at the build logs.
  4. Check if the failure is related to this commit (d58ebf0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1426/builds/55

Failed tests:

  • test_datetime

Failed subtests:

  • test_utc_alias - test.datetimetester.TestModule_Fast.test_utc_alias

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-x86_64.lto-pgo/build/Lib/test/datetimetester.py", line 98, in test_utc_alias self.assertIs(UTC, timezone.utc) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ AssertionError: datetime.timezone(datetime.timedelta(0)) is not datetime.timezone.utc 
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Fedora Stable LTO 3.13 has failed when building commit d58ebf0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1490/builds/51) and take a look at the build logs.
  4. Check if the failure is related to this commit (d58ebf0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1490/builds/51

Failed tests:

  • test_datetime

Failed subtests:

  • test_utc_alias - test.datetimetester.TestModule_Fast.test_utc_alias

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-x86_64.lto/build/Lib/test/datetimetester.py", line 98, in test_utc_alias self.assertIs(UTC, timezone.utc) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ AssertionError: datetime.timezone(datetime.timedelta(0)) is not datetime.timezone.utc 
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora LTO + PGO 3.13 has failed when building commit d58ebf0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1511/builds/54) and take a look at the build logs.
  4. Check if the failure is related to this commit (d58ebf0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1511/builds/54

Failed tests:

  • test_datetime

Failed subtests:

  • test_utc_alias - test.datetimetester.TestModule_Fast.test_utc_alias

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/dje/cpython-buildarea/3.13.edelsohn-fedora-z.lto-pgo/build/Lib/test/datetimetester.py", line 98, in test_utc_alias self.assertIs(UTC, timezone.utc) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ AssertionError: datetime.timezone(datetime.timedelta(0)) is not datetime.timezone.utc 
ericsnowcurrently added a commit that referenced this pull request May 28, 2024
…me (#119639) Revert "[3.13] gh-117398: Add multiphase support to _datetime (gh-119373) (gh-119636)" This reverts commit d58ebf0.
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable LTO + PGO 3.13 has failed when building commit d58ebf0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1433/builds/65) and take a look at the build logs.
  4. Check if the failure is related to this commit (d58ebf0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1433/builds/65

Failed tests:

  • test_datetime

Failed subtests:

  • test_utc_alias - test.datetimetester.TestModule_Fast.test_utc_alias

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.lto-pgo/build/Lib/test/datetimetester.py", line 98, in test_utc_alias self.assertIs(UTC, timezone.utc) ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^ AssertionError: datetime.timezone(datetime.timedelta(0)) is not datetime.timezone.utc 
@vstinner
Copy link
Member

This change introduced a reference leak: see issue gh-119655.

estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
This is minimal support. Subinterpreters are not supported yet. That will be addressed in a later change. Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

6 participants