Use fail-fast: false in mypy.yml #119297
Merged
Use fail-fast: false in mypy.yml #119297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I think it makes sense not to cancel all other mypy builds if one fails. See docs about this setting: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast
hugovk approved these changes May 21, 2024
hugovk added needs backport to 3.12 
| Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2024
See docs about this setting: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actionsGH-jobsjob_idstrategyfail-fast (cherry picked from commit b365332) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
| Sorry, @sobolevn and @AlexWaygood, I could not cleanly backport this to |
| GH-119304 is a backport of this pull request to the 3.13 branch. |
AlexWaygood pushed a commit that referenced this pull request May 21, 2024
Use `fail-fast: false` in `mypy.yml` (GH-119297) See docs about this setting: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actionsGH-jobsjob_idstrategyfail-fast (cherry picked from commit b365332) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Member Author
| 3.12 does not have this code: https://github.com/python/cpython/blob/3.12/.github/workflows/mypy.yml |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I think it makes sense not to cancel all other mypy builds if one fails.
See docs about this setting: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast