gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context #119222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
mjdominus changed the title mjdominus changed the title mjdominus changed the title 
encukou changed the title 
encukou added needs backport to 3.12 
| Thanks @mjdominus for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2024
…expr_context (pythonGH-119222) Add test coverage for "starred kind" in _PyPegen_set_expr_context (cherry picked from commit 8231a24) Co-authored-by: Mark Jason Dominus (陶敏修) <mjd@pobox.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2024
…expr_context (pythonGH-119222) Add test coverage for "starred kind" in _PyPegen_set_expr_context (cherry picked from commit 8231a24) Co-authored-by: Mark Jason Dominus (陶敏修) <mjd@pobox.com>
| GH-119263 is a backport of this pull request to the 3.13 branch. |
| GH-119264 is a backport of this pull request to the 3.12 branch. |
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
…expr_context (pythonGH-119222) Add test coverage for "starred kind" in _PyPegen_set_expr_context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
gh-94808: Add test coverage for "starred kind" in _PyPegen_set_expr_context
That item is on the gh-94808 checklist, but not checked off. I ran
lcovto confirm that the branch was not covered, added and ran the test, and rebuilt the coverage report to confirm that the branch had now been covered.This pertains to the production
at line 1057 in
python.gram.Thanks to @encukou for much guidance through this process.