gh-119053: Implement the fast path for list.__getitem__ #119112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
corona10 changed the title 
corona10 changed the title 
corona10 commented May 17, 2024
mpage reviewed May 17, 2024
mpage approved these changes May 18, 2024
Contributor
There was a problem hiding this comment.
This looks good to me. I noticed that we perform a validity check on the index several times now:
- In list_item
- In list_get_item_ref
- In list_item_impl (if we end up taking the slow path)
While this doesn't affect correctness, I think it would make sense to refactor the code to eliminate the redundant checks given how performance sensitive this code is. That could be tackled in a separate PR, though.
colesbury reviewed May 18, 2024
colesbury approved these changes May 20, 2024
| Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 21, 2024
…gh-119112) (cherry picked from commit ab4263a) Co-authored-by: Donghee Na <donghee.na@python.org>
| GH-119309 is a backport of this pull request to the 3.13 branch. |
corona10 added a commit that referenced this pull request May 21, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
list.__getitem__#119053