gh-118998: Handle errors correctly in tmtotuple in timemodule #118999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sobolevn added skip news needs backport to 3.12 
Eclips4 approved these changes May 13, 2024
| Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Member Author
| Thanks for the reviews! |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 13, 2024
…e` (pythonGH-118999) (cherry picked from commit fc75792) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 13, 2024
…e` (pythonGH-118999) (cherry picked from commit fc75792) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
| GH-119018 is a backport of this pull request to the 3.13 branch. |
| GH-119019 is a backport of this pull request to the 3.12 branch. |
sobolevn added a commit that referenced this pull request May 13, 2024
sobolevn added a commit that referenced this pull request May 13, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I tried to keep the diff as minimal as possible.
tmtotupleintimemodule#118998