gh-118507 : Refactor nt._path_is*

Lib/ntpath.py

@@ -288,21 +288,6 @@ def dirname(p):
  return split(p)[0]
 
 
-# Is a path a junction?
-
-if hasattr(os.stat_result, 'st_reparse_tag'):
- def isjunction(path):
- """Test whether a path is a junction"""
- try:
- st = os.lstat(path)
- except (OSError, ValueError, AttributeError):
- return False
- return st.st_reparse_tag == stat.IO_REPARSE_TAG_MOUNT_POINT
-else:
- # Use genericpath.isjunction as imported above
- pass
-
-
 # Is a path a mount point?
 # Any drive letter root (eg c:\)
 # Any share UNC (eg \\server\share)
@@ -917,6 +902,7 @@ def commonpath(paths):
  from nt import _path_isdir as isdir
  from nt import _path_isfile as isfile
  from nt import _path_islink as islink
+ from nt import _path_isjunction as isjunction
  from nt import _path_exists as exists
 except ImportError:
  # Use genericpath.* as imported above

Lib/test/test_ntpath.py

@@ -1095,6 +1095,11 @@ def test_isfile_driveletter(self):
  raise unittest.SkipTest('SystemDrive is not defined or malformed')
  self.assertFalse(os.path.isfile('\\\\.\\' + drive))
 
+ @unittest.skipUnless(hasattr(os, 'pipe'), "need os.pipe()")
+ def test_isfile_pipe(self):
+ pr, _ = os.pipe()
+ self.assertFalse(ntpath.isfile(pr))
+
  @unittest.skipIf(sys.platform != 'win32', "windows only")
  def test_con_device(self):
  self.assertFalse(os.path.isfile(r"\\.\CON"))
@@ -1114,6 +1119,8 @@ def test_fast_paths_in_use(self):
  self.assertFalse(inspect.isfunction(os.path.isfile))
  self.assertTrue(os.path.islink is nt._path_islink)
  self.assertFalse(inspect.isfunction(os.path.islink))
+ self.assertTrue(os.path.isjunction is nt._path_isjunction)
+ self.assertFalse(inspect.isfunction(os.path.isjunction))
  self.assertTrue(os.path.exists is nt._path_exists)
  self.assertFalse(inspect.isfunction(os.path.exists))
 

Misc/NEWS.d/next/Core and Builtins/2024-05-08-18-33-07.gh-issue-118507.OCQsAY.rst

@@ -0,0 +1 @@
+Speedup :func:`os.path.isjunction` on Windows with a native implementation.